Added existingSecret support for mysql and redis #972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…plates/_env.tpl for redis to follow the same format across whole file
1bd3460 to
91a9cb3
Compare
|
@joeyorlando sorry for pinging you directly, but I saw you reviewed a couple of helm-related PRs. May I ask you to take a look? |
|
hi there @artem-timchenko 👋 ! cc: @iskhakov (he's a bit more familiar w/ the helm charts) |
|
See also #1016. It includes similar changes and more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds existingSecret support for mysql and redis;
Fixes layout of templates/_env.tpl for redis to follow the same format across the whole file (main snippet -> snippets for fields)
Which issue(s) this PR fixes
#955
Checklist
CHANGELOG.mdupdatedNot sure is CHANGELOG should be updated, but can do this easily if required.