fix existingSecret for RabbitMQ to default value (see #761) #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
joeyorlando
approved these changes
Jun 15, 2023
iskhakov
approved these changes
Jun 16, 2023
Ukochka
pushed a commit
that referenced
this pull request
Jun 16, 2023
**What this PR does**: The existing value brokes the release when using external RabbitMQ. ``` Warning Failed 6s (x11 over 112s) kubelet Error: couldn't find key password in Secret monitoring/oncall-rabbitmq-external ``` **Which issue(s) this PR fixes**: Related MR [#761](#761) **Checklist** - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated --------- Co-authored-by: Ildar Iskhakov <Ildar.iskhakov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The existing value brokes the release when using external RabbitMQ.
Which issue(s) this PR fixes:
Related MR #761
Checklist
CHANGELOG.mdupdated