Cleaning out Incident word from frontend #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi there @Ukochka 👋 |
joeyorlando
reviewed
Feb 5, 2023
| @@ -63,7 +63,7 @@ const IncidentMatcher = observer((props: IncidentMatcherProps) => { | |||
| <div className={cx('columns')}> | |||
| <div className={cx('incident-list')}> | |||
| <Text.Title className={cx('title')} level={5}> | |||
| Matching Incidents | |||
| Matching Alert groups | |||
There was a problem hiding this comment.
should the "g" in "groups" also be capitalized if we're going to capitalize "Alert"?
joeyorlando
reviewed
Feb 5, 2023
grafana-plugin/src/plugin.json
Outdated
| @@ -31,7 +31,7 @@ | |||
| "includes": [ | |||
| { | |||
| "type": "page", | |||
| "name": "Incidents", | |||
| "name": "Alert groups", | |||
There was a problem hiding this comment.
same w/ capitalization here.
joeyorlando
reviewed
Feb 5, 2023
| label="Require resolution note when resolve incident" | ||
| description={`Once user clicks "Resolve" for an incident they are require to fill a resolution note about the incident`} | ||
| label="Require resolution note when resolve alert group" | ||
| description={`Once user clicks "Resolve" for an alert group they are require to fill a resolution note about the alert group`} |
There was a problem hiding this comment.
Suggested change
| description={`Once user clicks "Resolve" for an alert group they are require to fill a resolution note about the alert group`} | |
| description={`Once user clicks "Resolve" for an alert group, they will be required to fill in a resolution note about the alert group`} |
joeyorlando
reviewed
Feb 5, 2023
| @@ -50,8 +50,8 @@ class SettingsPage extends React.Component<SettingsPageProps, SettingsPageState> | |||
| <div className={cx('settings')}> | |||
| <Field | |||
| loading={!teamStore.currentTeam} | |||
| label="Require resolution note when resolve incident" | |||
| description={`Once user clicks "Resolve" for an incident they are require to fill a resolution note about the incident`} | |||
| label="Require resolution note when resolve alert group" | |||
There was a problem hiding this comment.
Suggested change
| label="Require resolution note when resolve alert group" | |
| label="Require a resolution note when resolving alert groups" |
joeyorlando
reviewed
Feb 5, 2023
teodosii
reviewed
Feb 6, 2023
| @@ -395,7 +395,7 @@ class IncidentPage extends React.Component<IncidentPageProps, IncidentPageState> | |||
| </li> | |||
| ))} | |||
| </ul> | |||
| <Field label="Leave a resolution note" description="Will also show up in the thread of incident in Slack"> | |||
| <Field label="Leave a resolution note" description="Will also show up in the thread of alert group in Slack"> | |||
There was a problem hiding this comment.
Shouldn't this be
show up in the thread of the alert group
or
should up in the thread of an alert group ?
Depending on usage, I'm not sure to which alert group we're referring to in this case. It is not correct as it is right now
teodosii
approved these changes
Feb 6, 2023
|
This should also have the change in the changelog I believe, it's good to keep track of all the frontend changes this way. |
…na/oncall into cleaning-incident-word-from-oncall
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
**What this PR does**: **Which issue(s) this PR fixes**: **Checklist** - [ ] Tests updated - [ ] Documentation added - [x] `CHANGELOG.md` updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated