Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve alert group deletion API #3124

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Improve alert group deletion API #3124

merged 4 commits into from
Oct 5, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Oct 5, 2023 •
edited
Loading

What this PR does

  • Invalidate alert group cache on wipe
  • Improve public API docs on alert group deletion
  • Add / improve tests

Which issue(s) this PR fixes

Related to #3051

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme changed the title API alert group deletion Improve alert group deletion API Oct 5, 2023
@vstpme vstpme marked this pull request as ready for review October 5, 2023 13:08
@vstpme vstpme requested a review from a team as a code owner October 5, 2023 13:08
@vstpme vstpme requested a review from a team October 5, 2023 13:08
@vstpme vstpme merged commit 1acb701 into dev Oct 5, 2023
@vstpme vstpme deleted the vadimkerr/fix-ag-delete branch October 5, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @matiasb