Update schedule filter events endpoint to return additional shift info #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
343fa17 to
cf78b29
Compare
vstpme
approved these changes
Oct 4, 2023
| @@ -70,6 +70,10 @@ def get_shift_end(self, obj): | |||
| def to_representation(self, instance): | |||
| ret = super().to_representation(instance) | |||
| ret["week_start"] = CustomOnCallShift.ICAL_WEEKDAY_MAP[instance.week_start] | |||
| if ret["schedule"] is None: | |||
| # for terraform based schedules, related schedule comes from M2M field | |||
| related_schedule = instance.schedules.last() | |||
There was a problem hiding this comment.
Just double checking: wouldn't this produce an SQL query for each on-call shift in the queryset? (N+1 issue)
There was a problem hiding this comment.
That's right, let me set a prefetch_related for this, pushing an update 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/grafana/oncall-private/issues/2191
This will also allow plugin to get shift name and type from the filter_events API, without needing to get details for each involved shift in the user's on-call summary timeline.