Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action/webhook API not accepting empty/null user #3094

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Fix action/webhook API not accepting empty/null user #3094

merged 3 commits into from
Oct 3, 2023

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Sep 30, 2023 •
edited
Loading

What this PR does

Fix update calls made by terraform when user field is empty or not present.
Should have been part of: #3053

Which issue(s) this PR fixes

grafana/terraform-provider-grafana#1025

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck requested a review from a team September 30, 2023 02:07
@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Sep 30, 2023
@mderynck mderynck added this pull request to the merge queue Oct 3, 2023
Merged via the queue into dev with commit d604fa1 Oct 3, 2023
@mderynck mderynck deleted the mderynck/webhook-public-api-fix branch October 3, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mderynck @matiasb