Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Slack ratelimit on alert group deletion #3038

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Handle Slack ratelimit on alert group deletion #3038

merged 2 commits into from
Sep 19, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Sep 18, 2023 •
edited
Loading

What this PR does

  • gracefully retry apps.alerts.tasks.delete_alert_group.delete_alert_group when hitting Slack ratelimits
  • remove Slack messages from the DB as soon as they are deleted from Slack, so the tasks are not retrying perpetually

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Sep 18, 2023
@vstpme vstpme force-pushed the vadimkerr/fix-alert-group-delete-slack-ratelimit branch from 7d1b3b6 to ed38cd9 Compare September 18, 2023 17:02
@vstpme vstpme marked this pull request as ready for review September 18, 2023 17:06
@vstpme vstpme requested a review from a team September 18, 2023 17:06
@vstpme vstpme enabled auto-merge September 19, 2023 08:37
@vstpme vstpme added this pull request to the merge queue Sep 19, 2023
Merged via the queue into dev with commit 6caacf4 Sep 19, 2023
@vstpme vstpme deleted the vadimkerr/fix-alert-group-delete-slack-ratelimit branch September 19, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @matiasb