Notify user when their shift swap request is taken #2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om:grafana/oncall into jorlando/notify-beneficiary-when-ssr-taken
joeyorlando
commented
Sep 7, 2023
| @@ -59,8 +59,6 @@ def _do_take(self, benefactor: User) -> dict: | |||
| new_state=shift_swap.insight_logs_serialized, | |||
| ) | |||
|
|
|||
| update_shift_swap_request_message.apply_async((shift_swap.pk,)) | |||
There was a problem hiding this comment.
moved to ShiftSwapRequest.take (as this needs to be done in two spots, incoming API requests as well as Slack events when clicking "Accept")
vstpme
approved these changes
Sep 7, 2023
Comment on lines
+227
to
+230
| "text": ( | ||
| f"{shift_swap_request.beneficiary.get_username_with_slack_verbal(True)} your teammate " | ||
| f"{shift_swap_request.benefactor.get_username_with_slack_verbal()} has taken the shift swap request" | ||
| ), |
There was a problem hiding this comment.
nit: Maybe just having <user> has taken the shift swap request could work better here?
I feel like addressing the SSR beneficiary directly would work well in DMs, but the thread message is visible to multiple people, so maybe it'd make sense to rephrase this so it's not directed at a single person?
|
|
||
| message: Message = mock_send_push_notification.call_args.args[1] | ||
| assert message.data["type"] == "oncall.info" | ||
| assert message.data["title"] == "Your shift swap request has been taken" |
There was a problem hiding this comment.
nit: maybe add a test to check that no one is getting push notifications except the beneficiary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #2868
Slack thread message
Push notification
Clicking on the push notification goes to the SSR detail view
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)