Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Slack integration leftovers after disconnecting #2986

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Fix Slack integration leftovers after disconnecting #2986

merged 3 commits into from
Sep 7, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Sep 6, 2023 •
edited
Loading

What this PR does

Improve Slack disconnect cleanup:

  • Reset Slack user group for schedules
  • Reset Slack user identity for deleted users

Which issue(s) this PR fixes

https://github.com/grafana/oncall-private/issues/1962

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Sep 6, 2023
@vstpme vstpme changed the title Improve Slack disconnect cleanup Fix Slack integration leftovers after disconnecting Sep 6, 2023
@vstpme vstpme marked this pull request as ready for review September 6, 2023 17:05
@vstpme vstpme requested a review from a team September 6, 2023 17:05
matiasb
matiasb approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstpme vstpme added this pull request to the merge queue Sep 7, 2023
Merged via the queue into dev with commit d90cf0f Sep 7, 2023
@vstpme vstpme deleted the vadimkerr/slack-integration-disconnect-leftovers branch September 7, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @matiasb