Refactor AlertGroup.slack_message
#2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md
vstpme
commented
Sep 4, 2023
Comment on lines
+13
to
+18
| operations = [ | ||
| common.migrations.remove_field.RemoveFieldState( | ||
| model_name='AlertGroup', | ||
| name='slack_message', | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Remove AlertGroup.slack_message so the only FK left is SlackMessage.alert_group
Comment on lines
-64
to
-79
| if e.response["error"] == "message_not_found": | ||
| logger.info(f"message_not_found for alert_group {alert_group.pk}, trying to post new message") | ||
| result = self._slack_client.api_call( | ||
| "chat.postMessage", channel=slack_message.channel_id, attachments=attachments, blocks=blocks | ||
| ) | ||
| slack_message_updated = SlackMessage( | ||
| slack_id=result["ts"], | ||
| organization=slack_message.organization, | ||
| _slack_team_identity=slack_message.slack_team_identity, | ||
| channel_id=slack_message.channel_id, | ||
| alert_group=alert_group, | ||
| ) | ||
| slack_message_updated.save() | ||
| alert_group.slack_message = slack_message_updated | ||
| alert_group.save(update_fields=["slack_message"]) | ||
| logger.info(f"Message has been posted for alert_group {alert_group.pk}") |
There was a problem hiding this comment.
Removing this logic completely because it's hard to maintain with the new FK structure.
I think it makes more sense to just ignore deleted AG Slack messages instead of trying to post a new message (why post a message one more time if the user already decided they don't want to see it and deleted it?)
matiasb
approved these changes
Sep 4, 2023
|
@matiasb yes, the DB field will be dropped in a future release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Refactors the foreign key relationship between
AlertGroupandSlackMessagemodels (see https://github.com/grafana/oncall-private/issues/1867 for more info).Which issue(s) this PR fixes
https://github.com/grafana/oncall-private/issues/1867
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)