Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint for getting schedules events for current user #2928

Merged
merged 16 commits into from
Sep 5, 2023
Merged

Add endpoint for getting schedules events for current user #2928

merged 16 commits into from
Sep 5, 2023

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented Aug 31, 2023 •
edited
Loading

What this PR does

Which issue(s) this PR fixes

#2915

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@Ferril Ferril added the pr:no public docs Added to a PR that does not require public documentation updates label Sep 1, 2023
@Ferril Ferril marked this pull request as ready for review September 4, 2023 07:57
@Ferril Ferril requested a review from a team September 4, 2023 07:57
matiasb
matiasb approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of minor suggestions.

engine/apps/schedules/tests/test_on_call_schedule.py Outdated Show resolved Hide resolved
engine/apps/schedules/models/on_call_schedule.py Show resolved Hide resolved
@Ferril Ferril added this pull request to the merge queue Sep 5, 2023
Merged via the queue into dev with commit ecb4ba0 Sep 5, 2023
@Ferril Ferril deleted the user-events-endpoint branch September 5, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ferril @matiasb