Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable shifts export endpoint for all schedule types #2863

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Enable shifts export endpoint for all schedule types #2863

merged 4 commits into from
Aug 23, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Aug 22, 2023

Related to #2799

@matiasb matiasb force-pushed the matiasb/enable-all-schedules-shifts-export branch from c4738d7 to c33c04a Compare August 22, 2023 20:36
@matiasb matiasb marked this pull request as ready for review August 22, 2023 20:45
@matiasb matiasb requested a review from a team as a code owner August 22, 2023 20:45
@matiasb matiasb requested a review from a team August 22, 2023 20:45
joeyorlando
joeyorlando approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Isn't there a caveat with Terraform/iCal schedules that if you change a rotation, it will change the historical shifts as well?

@matiasb
Copy link
Contributor Author

matiasb commented Aug 23, 2023

Isn't there a caveat with Terraform/iCal schedules that if you change a rotation, it will change the historical shifts as well?

Correct, but we have now also enabled "in-place" rotation updates for web schedules (almost like the preferred action when changing a rotation), so the situation is similar for all of them. In fact, let me add an explicit note about this in the documentation before merging.

@matiasb matiasb force-pushed the matiasb/enable-all-schedules-shifts-export branch from ea31906 to 547e194 Compare August 23, 2023 13:41
@matiasb matiasb merged commit 2c2497e into dev Aug 23, 2023
@matiasb matiasb deleted the matiasb/enable-all-schedules-shifts-export branch August 23, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @joeyorlando