Don't send notifications about past SSRs when turning on info notifications #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasb
approved these changes
Aug 11, 2023
| @@ -595,10 +595,10 @@ def _should_notify_user_about_shift_swap_request( | |||
| except MobileAppUserSettings.DoesNotExist: | |||
| return False # don't notify if the app is not configured | |||
|
|
|||
| return ( | |||
| mobile_app_user_settings.info_notifications_enabled # info notifications must be enabled | |||
There was a problem hiding this comment.
If I understand it ok, the idea is to flag the swap request as notified if a notification should have been sent while notifications are disabled, so when enabling we don't try to send it later, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes a bug when a user is receiving push notifications about past SSRs after turning on the info notifications in the mobile app.
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)