Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shift swaps endpoints to public API #2775

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Add shift swaps endpoints to public API #2775

merged 3 commits into from
Aug 14, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Aug 10, 2023

Related to #2678

@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 10, 2023
@matiasb matiasb force-pushed the matiasb/shift-swap-api branch from d562a7f to a0e6716 Compare August 10, 2023 18:36
@matiasb matiasb marked this pull request as ready for review August 10, 2023 18:55
@matiasb matiasb requested a review from a team August 10, 2023 18:55
vstpme
vstpme approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@vstpme vstpme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine/apps/public_api/views/shift_swap.py Outdated Show resolved Hide resolved
engine/apps/public_api/views/shift_swap.py Outdated Show resolved Hide resolved
@matiasb matiasb force-pushed the matiasb/shift-swap-api branch from 091323e to 6412b65 Compare August 11, 2023 18:31
@matiasb matiasb mentioned this pull request Aug 11, 2023
Merged
@matiasb matiasb added this pull request to the merge queue Aug 14, 2023
Merged via the queue into dev with commit 5e5eecc Aug 14, 2023
@matiasb matiasb deleted the matiasb/shift-swap-api branch August 14, 2023 12:31
matiasb added a commit that referenced this pull request Aug 16, 2023
@matiasb
Add shift swaps API docs (#2784)
a459d8b 
API added by #2775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstpme vstpme vstpme approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @vstpme