Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out untaken swaps from final schedule and shift notifications #2748

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Filter out untaken swaps from final schedule and shift notifications #2748

merged 2 commits into from
Aug 4, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Aug 3, 2023

Avoid creating (or notifying) about potential event splits resulting from untaken swap requests.

@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label Aug 3, 2023
@matiasb matiasb marked this pull request as ready for review August 3, 2023 20:25
@matiasb matiasb requested a review from a team August 3, 2023 20:25
@matiasb matiasb force-pushed the final-schedule-ignore-untaken-swaps branch 2 times, most recently from dee7c57 to 8ad6c88 Compare August 4, 2023 12:57
@matiasb matiasb force-pushed the final-schedule-ignore-untaken-swaps branch from 8ad6c88 to 10cdd42 Compare August 4, 2023 15:28
vstpme
vstpme approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@vstpme vstpme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasb matiasb added this pull request to the merge queue Aug 4, 2023
Merged via the queue into dev with commit bb9f647 Aug 4, 2023
@matiasb matiasb deleted the final-schedule-ignore-untaken-swaps branch August 4, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstpme vstpme vstpme approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @vstpme