Fix alerts.0028 migration for SQLite
#2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstpme
commented
Jul 28, 2023
| @@ -10,7 +10,7 @@ RUN apt-get update && apt-get install -y \ | |||
| gcc \ | |||
| libmariadb-dev \ | |||
| libpq-dev \ | |||
| netcat \ | |||
| netcat-traditional \ | |||
There was a problem hiding this comment.
For Debian 12, it's required to specify netcat-traditional vs netcat-openbsd explicitly. Previously we used netcat-traditional, so leaving it as is.
mderynck
approved these changes
Jul 28, 2023
vstpme
added a commit
that referenced
this pull request
Jul 28, 2023
# What this PR does Fixes an issue with [alerts.0028](https://github.com/grafana/oncall/blob/f77a54b518ab8f1f42e33ca43328b75fde1903b9/engine/apps/alerts/migrations/0028_drop_alertreceivechannel_restricted_at.py) migration failing on SQLite with the following error: `sqlite3.OperationalError: near "DROP": syntax error`. The issue is fixed by updating the SQLite version from `3.27.2` to `3.40.1` (SQLite `3.35.0` introduced native support for dropping columns as per this [SO answer](https://stackoverflow.com/a/66399224)). However, I couldn't find an easy way to independently update SQLite, since it's bundled into Python's standard library. Updating the Docker image to use the latest Debian stable release fixes the issue as it already comes with SQLite `3.40.1` out of the box. So this PR effectively bumps the Debian version from 10 to 12, and bumps the Python version from `3.11.3` to `3.11.4`. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
joeyorlando
reviewed
Jul 28, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes an issue with alerts.0028 migration failing on SQLite with the following error:
sqlite3.OperationalError: near "DROP": syntax error.The issue is fixed by updating the SQLite version from
3.27.2to3.40.1(SQLite3.35.0introduced native support for dropping columns as per this SO answer).However, I couldn't find an easy way to independently update SQLite, since it's bundled into Python's standard library.
Updating the Docker image to use the latest Debian stable release fixes the issue as it already comes with SQLite
3.40.1out of the box. So this PR effectively bumps the Debian version from 10 to 12, and bumps the Python version from3.11.3to3.11.4.Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)