Remove checks that slow down plugin load and cause "Initializing plugin..." #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
approved these changes
Jul 24, 2023
mderynck
reviewed
Jul 24, 2023
mderynck
reviewed
Jul 24, 2023
iskhakov
commented
Jul 25, 2023
1ba3225 to
20a327b
Compare
joeyorlando
reviewed
Jul 26, 2023
Comment on lines
+218
to
+222
| const pluginLink = ( | ||
| <LinkButton href={`/a/grafana-oncall-app/`} variant="primary"> | ||
| Open Grafana OnCall | ||
| </LinkButton> | ||
| ); |
joeyorlando
reviewed
Jul 26, 2023
Comment on lines
+157
to
+159
| if (!FaroHelper.faro) { | ||
| FaroHelper.initializeFaro(this.onCallApiUrl); | ||
| } |
There was a problem hiding this comment.
right. I just wasn't sure why this line was all of a sudden being added here but now I see it was removed here. makes sense 👍
teodosii
approved these changes
Jul 26, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
…in..." (#2624) # What this PR does * Removes "Initializing plugin.." message during load * Removes black screen when plugin loads * Removes wait for syncs between OnCall and Grafana * Deprecates GET /status, POST /sync, GET /sync in favour of single POST /status ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)