Remove unnecessary team checks #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
reviewed
Jul 21, 2023
| for shift in shifts: | ||
| shift_team_id = shift.team.public_primary_key if shift.team else None | ||
| if shift_team_id != team_id: | ||
| raise BadRequest(detail="Shifts must be assigned to the same team as the schedule") |
There was a problem hiding this comment.
Is there a case when shift belongs to the other team from the schedule?
There was a problem hiding this comment.
I don't think it's possible now but should be possible after merging this PR. I tried to create a shift for team X and a schedule for team Y using that shift, there were no issues with it. So unless we have a particular reason to enforce team checks here, I'd propose to remove them so it's consistent with other models.
mderynck
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes unnecessary team checks enforced by public API, as they seem to be outdated and not aligned with the web UI and docs.
From public docs:
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)