Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current responders -> Additional Responders #2567

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Jul 18, 2023

What this PR does

Changes wording so it's clear that only "additional" responders (i.e. users paged through direct paging) are shown in this section, and users paged via escalation chain are not shown.

Before:

Screenshot 2023-07-18 at 10 15 28

After:

Screenshot 2023-07-18 at 10 16 06

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme requested a review from a team July 18, 2023 09:16
@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Jul 18, 2023
@vstpme vstpme added this pull request to the merge queue Jul 18, 2023
Merged via the queue into dev with commit 94fd91d Jul 18, 2023
@vstpme vstpme deleted the vadimkerr/responders-web-wording branch July 18, 2023 11:37
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does

Changes wording so it's clear that only "additional" responders (i.e.
users paged through direct paging) are shown in this section, and users
paged via escalation chain are not shown.

Before:

<img width="601" alt="Screenshot 2023-07-18 at 10 15 28"
src="https://github.com/grafana/oncall/assets/20116910/a152692f-2f2b-46e5-b51a-71acc9a25b7d">

After:

<img width="601" alt="Screenshot 2023-07-18 at 10 16 06"
src="https://github.com/grafana/oncall/assets/20116910/6ff95c72-a883-4a7a-a81a-4ae7fe11877f">

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants