remove deprecated backend code

engine/apps/alerts/migrations/0020_auto_20230711_1532.py

@@ -0,0 +1,26 @@
+# Generated by Django 3.2.20 on 2023-07-11 15:32
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('alerts', '0019_auto_20230705_1619'),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name='alertgroup',
+            name='active_cache_for_web_calculation_id',
+        ),
+        migrations.RemoveField(
+            model_name='alertgroup',
+            name='estimate_escalation_finish_time',
+        ),
+        migrations.AlterField(
+            model_name='alertgroup',
+            name='cached_render_for_web',
+            field=models.JSONField(default=dict, null=True),
+        ),
+    ]

engine/apps/alerts/models/alert_group.py

@@ -163,7 +163,7 @@ class AlertGroup(AlertGroupSlackRenderingMixin, EscalationSnapshotMixin, models.
         (USER, "user"),
         (NOT_YET, "not yet"),
         (LAST_STEP, "last escalation step"),
-        (ARCHIVED, "archived"),
+        (ARCHIVED, "archived"),  # deprecated. don't use
         (WIPED, "wiped"),
         (DISABLE_MAINTENANCE, "stop maintenance"),
         (NOT_YET_STOP_AUTORESOLVE, "not yet, autoresolve disabled"),
@@ -327,9 +327,8 @@ def status(self):
         related_name="dependent_alert_groups",
     )
 
-    # cached_render_for_web and active_cache_for_web_calculation_id are deprecated
-    cached_render_for_web = models.JSONField(default=dict)
-    active_cache_for_web_calculation_id = models.CharField(max_length=100, null=True, default=None)
+    # TODO: remove cached_render_for_web in a subsequent release
+    cached_render_for_web = deprecate_field(models.JSONField(default=dict))
 
     # NOTE: we should probably migrate this field to models.UUIDField as it's ONLY ever being
     # set to the result of uuid.uuid1
@@ -361,9 +360,6 @@ def status(self):
 
     raw_escalation_snapshot = JSONField(null=True, default=None)
 
-    # THIS FIELD IS DEPRECATED AND SHOULD EVENTUALLY BE REMOVED
-    estimate_escalation_finish_time = deprecate_field(models.DateTimeField(null=True, default=None))
-
     # This field is used for constraints so we can use get_or_create() in concurrent calls
     # https://docs.djangoproject.com/en/3.2/ref/models/querysets/#get-or-create
     # Combined with unique_together below, it allows only one alert group with
@@ -715,38 +711,6 @@ def resolve_by_source(self):
         for dependent_alert_group in self.dependent_alert_groups.all():
             dependent_alert_group.resolve_by_source()
 
-    # deprecated
-    def resolve_by_archivation(self):
-        AlertGroupLogRecord = apps.get_model("alerts", "AlertGroupLogRecord")
-        # if incident was silenced, unsilence it without starting escalation
-        if self.silenced:
-            self.un_silence()
-            self.log_records.create(
-                type=AlertGroupLogRecord.TYPE_UN_SILENCE,
-                silence_delay=None,
-                reason="Resolve by archivation",
-            )
-        self.archive()
-        self.stop_escalation()
-        if not self.resolved:
-            self.resolve(resolved_by=AlertGroup.ARCHIVED)
-
-            log_record = self.log_records.create(type=AlertGroupLogRecord.TYPE_RESOLVED)
-
-            logger.debug(
-                f"send alert_group_action_triggered_signal for alert_group {self.pk}, "
-                f"log record {log_record.pk} with type '{log_record.get_type_display()}', action source: archivation"
-            )
-
-            alert_group_action_triggered_signal.send(
-                sender=self.resolve_by_archivation,
-                log_record=log_record.pk,
-                action_source=None,
-            )
-
-        for dependent_alert_group in self.dependent_alert_groups.all():
-            dependent_alert_group.resolve_by_archivation()
-
     def resolve_by_last_step(self):
         AlertGroupLogRecord = apps.get_model("alerts", "AlertGroupLogRecord")
         initial_state = self.state

engine/apps/alerts/tasks/resolve_alert_group_by_source_if_needed.py

@@ -31,7 +31,7 @@ def resolve_alert_group_by_source_if_needed(alert_group_pk):
             alert_group.save(update_fields=["resolved_by"])
         if alert_group.resolved_by == alert_group.NOT_YET_STOP_AUTORESOLVE:
             return "alert_group is too big to auto-resolve"
-        print("YOLO")
+
         last_alert = AlertForAlertManager.objects.get(pk=alert_group.alerts.last().pk)
         if alert_group.is_alert_a_resolve_signal(last_alert):
             alert_group.resolve_by_source()

engine/apps/api/serializers/organization.py

@@ -1,31 +1,15 @@
-import datetime
 from dataclasses import asdict
 
-import humanize
-import pytz
 from django.apps import apps
-from django.utils import timezone
-from rest_framework import fields, serializers
+from rest_framework import serializers
 
 from apps.base.models import LiveSetting
 from apps.phone_notifications.phone_provider import get_phone_provider
 from apps.slack.models import SlackTeamIdentity
-from apps.slack.tasks import resolve_archived_incidents_for_organization, unarchive_incidents_for_organization
 from apps.user_management.models import Organization
 from common.api_helpers.mixins import EagerLoadingMixin
 
 
-class CustomDateField(fields.TimeField):
-    def to_internal_value(self, data):
-        try:
-            archive_datetime = datetime.datetime.fromisoformat(data).astimezone(pytz.UTC)
-        except (TypeError, ValueError):
-            raise serializers.ValidationError({"archive_alerts_from": ["Invalid date format"]})
-        if archive_datetime.date() >= timezone.now().date():
-            raise serializers.ValidationError({"archive_alerts_from": ["Invalid date. Date must be less than today."]})
-        return archive_datetime
-
-
 class FastSlackTeamIdentitySerializer(serializers.ModelSerializer):
     class Meta:
         model = SlackTeamIdentity
@@ -37,7 +21,6 @@ class OrganizationSerializer(EagerLoadingMixin, serializers.ModelSerializer):
     slack_team_identity = FastSlackTeamIdentitySerializer(read_only=True)
 
     name = serializers.CharField(required=False, allow_null=True, allow_blank=True, source="org_title")
-    # name_slug = serializers.CharField(required=False, allow_null=True, allow_blank=False)
     maintenance_till = serializers.ReadOnlyField(source="till_maintenance_timestamp")
     slack_channel = serializers.SerializerMethodField()
 
@@ -48,21 +31,15 @@ class Meta:
         fields = [
             "pk",
             "name",
-            # "name_slug",
-            # "is_new_version",
             "slack_team_identity",
             "maintenance_mode",
             "maintenance_till",
-            # "incident_retention_web_report",
-            # "number_of_employees",
             "slack_channel",
         ]
         read_only_fields = [
-            "is_new_version",
             "slack_team_identity",
             "maintenance_mode",
             "maintenance_till",
-            # "incident_retention_web_report",
         ]
 
     def get_slack_channel(self, obj):
@@ -82,22 +59,18 @@ def get_slack_channel(self, obj):
 
 
 class CurrentOrganizationSerializer(OrganizationSerializer):
-    limits = serializers.SerializerMethodField()
     env_status = serializers.SerializerMethodField()
     banner = serializers.SerializerMethodField()
 
     class Meta(OrganizationSerializer.Meta):
         fields = [
             *OrganizationSerializer.Meta.fields,
-            "limits",
-            "archive_alerts_from",
             "is_resolution_note_required",
             "env_status",
             "banner",
         ]
         read_only_fields = [
             *OrganizationSerializer.Meta.read_only_fields,
-            "limits",
             "banner",
         ]
 
@@ -109,10 +82,6 @@ def get_banner(self, obj):
         )[0]
         return banner.json_value
 
-    def get_limits(self, obj):
-        user = self.context["request"].user
-        return obj.notifications_limit_web_report(user)
-
     def get_env_status(self, obj):
         # deprecated in favour of ConfigAPIView.
         # All new env statuses should be added there
@@ -122,44 +91,9 @@ def get_env_status(self, obj):
         phone_provider_config = get_phone_provider().flags
         return {
             "telegram_configured": telegram_configured,
-            "twilio_configured": phone_provider_config.configured,  # keep for backward compatibility
             "phone_provider": asdict(phone_provider_config),
         }
 
-    def get_stats(self, obj):
-        if isinstance(obj.cached_seconds_saved_by_amixr, int):
-            verbal_time_saved_by_amixr = humanize.naturaldelta(
-                datetime.timedelta(seconds=obj.cached_seconds_saved_by_amixr)
-            )
-        else:
-            verbal_time_saved_by_amixr = None
-
-        result = {
-            "grouped_percent": obj.cached_grouped_percent,
-            "alerts_count": obj.cached_alerts_count,
-            "noise_reduction": obj.cached_noise_reduction,
-            "average_response_time": humanize.naturaldelta(obj.cached_average_response_time),
-            "verbal_time_saved_by_amixr": verbal_time_saved_by_amixr,
-        }
-
-        return result
-
-    def update(self, instance, validated_data):
-        current_archive_date = instance.archive_alerts_from
-        archive_alerts_from = validated_data.get("archive_alerts_from")
-
-        result = super().update(instance, validated_data)
-        if archive_alerts_from is not None and current_archive_date != archive_alerts_from:
-            if current_archive_date > archive_alerts_from:
-                unarchive_incidents_for_organization.apply_async(
-                    (instance.pk,),
-                )
-            resolve_archived_incidents_for_organization.apply_async(
-                (instance.pk,),
-            )
-
-        return result
-
 
 class FastOrganizationSerializer(serializers.ModelSerializer):
     pk = serializers.CharField(read_only=True, source="public_primary_key")

engine/apps/api/urls.py

@@ -35,7 +35,6 @@
     SlackTeamSettingsAPIView,
     UnAcknowledgeTimeoutOptionsAPIView,
 )
-from .views.subscription import SubscriptionView
 from .views.team import TeamViewSet
 from .views.telegram_channels import TelegramChannelViewSet
 from .views.user import CurrentUserView, UserView
@@ -83,7 +82,6 @@
         GetChannelVerificationCode.as_view(),
         name="api-get-channel-verification-code",
     ),
-    optional_slash_path("current_subscription", SubscriptionView.as_view(), name="subscription"),
     optional_slash_path("terraform_file", TerraformGitOpsView.as_view(), name="terraform_file"),
     optional_slash_path("terraform_imports", TerraformStateView.as_view(), name="terraform_imports"),
     optional_slash_path("maintenance", MaintenanceAPIView.as_view(), name="maintenance"),

engine/apps/slack/scenarios/alertgroup_appearance.py

@@ -5,10 +5,10 @@
 from apps.api.permissions import RBACPermission
 from apps.slack.scenarios import scenario_step
 
-from .step_mixins import AlertGroupActionsMixin, CheckAlertIsUnarchivedMixin
+from .step_mixins import AlertGroupActionsMixin
 
 
-class OpenAlertAppearanceDialogStep(CheckAlertIsUnarchivedMixin, AlertGroupActionsMixin, scenario_step.ScenarioStep):
+class OpenAlertAppearanceDialogStep(AlertGroupActionsMixin, scenario_step.ScenarioStep):
     REQUIRED_PERMISSIONS = [RBACPermission.Permissions.CHATOPS_WRITE]
 
     def process_scenario(self, slack_user_identity, slack_team_identity, payload):
@@ -17,9 +17,6 @@ def process_scenario(self, slack_user_identity, slack_team_identity, payload):
             self.open_unauthorized_warning(payload)
             return
 
-        if not self.check_alert_is_unarchived(slack_team_identity, payload, alert_group):
-            return
-
         private_metadata = {
             "organization_id": self.organization.pk if self.organization else alert_group.organization.pk,
             "alert_group_pk": alert_group.pk,