Unhide direct paging integration #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
commented
Jul 10, 2023
7422340 to
f29c9dc
Compare
iskhakov
commented
Jul 10, 2023
Matvey-Kuk
approved these changes
Jul 10, 2023
maskin25
suggested changes
Jul 11, 2023
grafana-plugin/src/containers/GrafanaTeamSelect/GrafanaTeamSelect.tsx
Outdated
Show resolved
Hide resolved
grafana-plugin/src/components/ManualAlertGroup/ManualAlertGroup.tsx
Outdated
Show resolved
Hide resolved
grafana-plugin/src/components/ManualAlertGroup/ManualAlertGroup.tsx
Outdated
Show resolved
Hide resolved
grafana-plugin/src/components/ManualAlertGroup/ManualAlertGroup.tsx
Outdated
Show resolved
Hide resolved
maskin25
reviewed
Jul 12, 2023
grafana-plugin/src/models/alert_receive_channel/alert_receive_channel.types.ts
Outdated
Show resolved
Hide resolved
maskin25
reviewed
Jul 12, 2023
| IntegrationHelper.getChatOpsChannels(alertReceiveChannelStore.channelFilters[channelFilterId], store) | ||
| .filter((channel) => channel) | ||
| .map((channel) => { | ||
| if (!channelKeys.has(channel.name + channel.icon)) { |
There was a problem hiding this comment.
it's better to extract this to var const channelKey = channel.name + channel.icon and use it below
maskin25
reviewed
Jul 12, 2023
| let channelKeys = new Set(); | ||
| filterIds.map((channelFilterId) => { | ||
| IntegrationHelper.getChatOpsChannels(alertReceiveChannelStore.channelFilters[channelFilterId], store) | ||
| .filter((channel) => channel) |
There was a problem hiding this comment.
weird that we need to filter here, why might they be nullable? maybe we need to filter them on backend side....
maskin25
reviewed
Jul 12, 2023
| {chatOpsAvailableChannels.map( | ||
| (chatOpsChannel: { name: string; icon: IconName }, chatOpsIndex) => ( | ||
| <div | ||
| key={`${chatOpsChannel?.name}-${chatOpsIndex}`} |
There was a problem hiding this comment.
maybe key=chatOpsChannel?.name+chatOpsChannel?.icon? and actually you can get rid of question mark here chatOpsChannel?.name because you iterate over array and chatOpsChannel cannot be undefined inside loop
maskin25
reviewed
Jul 12, 2023
| @@ -960,6 +960,17 @@ const HowToConnectComponent: React.FC<{ id: AlertReceiveChannel['id'] }> = ({ id | |||
| const item = alertReceiveChannelStore.items[id]; | |||
| const url = item?.integration_url || item?.inbound_email; | |||
|
|
|||
| const howToConnectTagName = (integration: string) => { | |||
There was a problem hiding this comment.
maybe use enum like
enum IntegrationKind {
DIRECT_PAGING='direct_paging',
EMAIL='email''
}
and map object to get names:
const integrationToName = { IntegrationKind.DIRECT_PAGING:'Manual'. IntegrationKind.EMAIL:'email' }
and then
const name=integrationToName[integration]||'HTTP Endpoint'
maskin25
approved these changes
Jul 12, 2023
iskhakov
commented
Jul 13, 2023
iskhakov
commented
Jul 13, 2023
iskhakov
commented
Jul 13, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Fixes #2442 https://github.com/grafana/oncall/assets/2262529/08bb8e5f-acc6-4f2d-9e38-717c9f37e3da ## Which issue(s) this PR fixes ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #2442
Screen.Recording.2023-07-10.at.11.12.07.PM.mov
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)