fix pagination next and previous links for schedules and integrations GET endpoints #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for schedules and integrations GET endpoints
mderynck
approved these changes
Jul 7, 2023
joeyorlando
commented
Jul 7, 2023
| @@ -219,7 +219,7 @@ def test_get_list_schedules_pagination( | |||
| client = APIClient() | |||
|
|
|||
| schedule_list_url = reverse("api-internal:schedule-list") | |||
| absolute_url = create_engine_url(schedule_list_url, override_base="http://testserver") | |||
There was a problem hiding this comment.
this should be fine. override_base has no effect here because the actual absolute URL that is being generated is overriden here on the actual request object itself in PathPrefixedCursorPagination.paginate_queryset:
class PathPrefixedPagination(PageNumberPagination):
def paginate_queryset(self, queryset, request, view=None):
request.build_absolute_uri = lambda: create_engine_url(request.get_full_path())
return super().paginate_queryset(queryset, request, view)
joeyorlando
commented
Jul 7, 2023
Comment on lines
-42
to
-49
| def paginate_queryset(self, queryset, request, view=None): | ||
| """Override to apply pagination only if ?page= is present in query params | ||
| Required for backwards compatibility with older versions | ||
| """ | ||
| page_number = request.query_params.get(self.page_query_param, None) | ||
| if not page_number: | ||
| return None | ||
| return super().paginate_queryset(queryset, request, view) |
There was a problem hiding this comment.
I think this can be removed. @iskhakov wdyt?
This was likely here to handle the transition when the paginated integration's page was release, and to handle the case in Cloud where UI clients running the previous version would've received a different API response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
closes #2463
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)