add debounce for GSelect and RemoteSelect #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2e tests + bump e2e test workers to 3
joeyorlando
reviewed
Jul 10, 2023
Comment on lines
-130
to
+127
| defaultOptions={options} | ||
| defaultOptions |
There was a problem hiding this comment.
what is this change for?
There was a problem hiding this comment.
from specs
defaultOptions | When specified as boolean the loadOptions will execute when component is mounted
it exactly what we need
There was a problem hiding this comment.
gotcha, thanks for clarifying 👍
joeyorlando
approved these changes
Jul 11, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Fix performance Issue in GSelect component when searching ## Which issue(s) this PR fixes #1628 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com> Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fix performance Issue in GSelect component when searching
Which issue(s) this PR fixes
#1628
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)