Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attempt to check token when editor/viewers are accessing the plugin #2410

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

mderynck
Copy link
Contributor

What this PR does

Remove attempt to check token when editor/viewers are accessing the plugin. Only check the token for reinstall during sync from the PluginConfigPage since only Admins would have access to it.

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

…ll the api token so that it is only called on the plugin config page and not when an editor or viewer would encounter it by accessing the regular plugin
@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Jun 29, 2023
@mderynck mderynck marked this pull request as ready for review June 29, 2023 19:41
@mderynck mderynck requested a review from a team June 29, 2023 19:41
@mderynck mderynck merged commit 2b81dfd into dev Jun 29, 2023
@mderynck mderynck deleted the mderynck/oncall-plugin-permission-fix branch June 29, 2023 20:17
brojd pushed a commit that referenced this pull request Sep 18, 2024
…lugin (#2410)

# What this PR does
Remove attempt to check token when editor/viewers are accessing the
plugin. Only check the token for reinstall during sync from the
PluginConfigPage since only Admins would have access to it.

## Which issue(s) this PR fixes

## Checklist

- [X] Unit, integration, and e2e (if applicable) tests updated
- [X] Documentation added (or `pr:no public docs` PR label added if not
required)
- [X] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant