Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to schedule rotation form and preview #2316

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Minor updates to schedule rotation form and preview #2316

merged 2 commits into from
Jun 23, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Jun 22, 2023

  • When editing a shift, use shiftStart as rotationStart value (originally, rotationStart was most of the time the timestamp of creation, which is confusing in the new form; otoh, for newly created shifts, the shiftStart will match rotationStart)
  • Since shift preview is requested starting the day before the start of the week, sometimes the displayed preview is missing the last day of the week (preview returns 7 days by default)

@matiasb matiasb requested a review from a team June 22, 2023 19:22
@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label Jun 22, 2023
@matiasb matiasb requested a review from maskin25 June 23, 2023 00:01
@matiasb matiasb force-pushed the matiasb/schedules-minor-updates branch from afe2f54 to b7cf555 Compare June 23, 2023 12:25
@matiasb matiasb added this pull request to the merge queue Jun 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 23, 2023
@matiasb matiasb added this pull request to the merge queue Jun 23, 2023
Merged via the queue into dev with commit 5f73af1 Jun 23, 2023
@matiasb matiasb deleted the matiasb/schedules-minor-updates branch June 23, 2023 16:38
brojd pushed a commit that referenced this pull request Sep 18, 2024
@matiasb
Minor updates to schedule rotation form and preview (#2316)
d4dff87 
- When editing a shift, use `shiftStart` as `rotationStart` value
(originally, `rotationStart` was most of the time the timestamp of
creation, which is confusing in the new form; otoh, for newly created
shifts, the `shiftStart` will match `rotationStart`)
- Since shift preview is requested starting the day before the start of
the week, sometimes the displayed preview is missing the last day of the
week (preview returns 7 days by default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maskin25 maskin25 maskin25 approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @maskin25