remove legacy permission strings #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grafana/grafana-oncall-frontend I took a glance at the frontend code and I do not see this attribute referenced anywhere. do you mind verifying that? |
joeyorlando
commented
Jun 16, 2023
| @@ -71,7 +67,7 @@ class Meta: | |||
| "email", | |||
| "username", | |||
| "name", | |||
| "role", # LEGACY.. this should get removed eventually | |||
| "role", | |||
There was a problem hiding this comment.
I think this was improperly marked as "LEGACY" during the RBAC work. role is still needed for the foreseeable future.
vstpme
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Remove deprecated
permissionsList[str]from internal API user response. These permission strings are no longer used and AFAICT are not referenced anywhere in the UI.Checklist
pr:no public docsPR label added if not required) (N/A)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)