Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Allow using existing secrets for redis and mysql #2156

Merged
merged 8 commits into from
Jun 13, 2023

Conversation

raz-amir
Copy link
Contributor

@raz-amir raz-amir commented Jun 12, 2023

What this PR does

This PR adds the ability to use an existing secret for external Redis and external MySQL and it follows the same changes that PR #761 did for RabbitMQ (including the fix that was done for it later in #775)

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2023

CLA assistant check
All committers have signed the CLA.

@raz-amir raz-amir force-pushed the ramir/redis_mysql_secrets branch from 00efc17 to efa336b Compare June 12, 2023 12:25
@raz-amir raz-amir marked this pull request as ready for review June 12, 2023 13:47
@raz-amir raz-amir requested a review from a team June 12, 2023 13:47
@iskhakov iskhakov self-assigned this Jun 13, 2023
Copy link
Contributor

@iskhakov iskhakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thank you for the contribution

@iskhakov iskhakov added this pull request to the merge queue Jun 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2023
@iskhakov iskhakov added this pull request to the merge queue Jun 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2023
@iskhakov iskhakov added this pull request to the merge queue Jun 13, 2023
@iskhakov iskhakov removed this pull request from the merge queue due to a manual request Jun 13, 2023
@iskhakov iskhakov enabled auto-merge June 13, 2023 05:38
@iskhakov iskhakov added this pull request to the merge queue Jun 13, 2023
Merged via the queue into grafana:dev with commit 40890e2 Jun 13, 2023
@raz-amir
Copy link
Contributor Author

Thank you @iskhakov . Can you tell when do you expect to have a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants