Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics doc #2149

Merged
merged 8 commits into from
Jun 21, 2023
Merged

Metrics doc #2149

merged 8 commits into from
Jun 21, 2023

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented Jun 9, 2023 •
edited
Loading

What this PR does

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

Matvey-Kuk
Matvey-Kuk approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it worth considering moving "Metrics" to the top because I expect them being more popular & used. Great docs btw!

matiasb
matiasb approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/sources/insights-and-metrics/_index.md Outdated Show resolved Hide resolved
docs/sources/insights-and-metrics/_index.md Outdated Show resolved Hide resolved
docs/sources/insights-and-metrics/_index.md Outdated Show resolved Hide resolved
docs/sources/insights-and-metrics/_index.md Outdated Show resolved Hide resolved
@Ferril Ferril marked this pull request as ready for review June 21, 2023 07:17
Ferril and others added 6 commits June 21, 2023 09:20
@Ferril
Draft metrics doc
1492f64
@Ferril
Move "Metrics" to the top of the doc
fa5cf68
@Ferril @matiasb
Update docs/sources/insights-and-metrics/_index.md
648d74f 
Co-authored-by: Matias Bordese <mbordese@gmail.com>
@Ferril @matiasb
Update docs/sources/insights-and-metrics/_index.md
7f25778 
Co-authored-by: Matias Bordese <mbordese@gmail.com>
@Ferril @matiasb
Update docs/sources/insights-and-metrics/_index.md
4185ccf 
Co-authored-by: Matias Bordese <mbordese@gmail.com>
@Ferril @matiasb
Update docs/sources/insights-and-metrics/_index.md
cf85da6 
Co-authored-by: Matias Bordese <mbordese@gmail.com>
@Ferril Ferril force-pushed the metrics-documentation branch from 2ef9d40 to cf85da6 Compare June 21, 2023 07:20
@Ferril Ferril changed the title Draft metrics doc Metrics doc Jun 21, 2023
@Ferril Ferril added this pull request to the merge queue Jun 21, 2023
Merged via the queue into dev with commit 0c46b41 Jun 21, 2023
@Ferril Ferril deleted the metrics-documentation branch June 21, 2023 11:10
@matiasb matiasb mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matvey-Kuk Matvey-Kuk Matvey-Kuk approved these changes

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ferril @matiasb @Matvey-Kuk