Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alert group view receive channel filter #2140

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Jun 8, 2023

We were noticing some discrepancies in alert groups counts.

From a real example:

# queryset is the alert groups initial queryset
>>> qs = queryset.filter(channel_filter__alert_receive_channel=arc)
>>> qs.filter(resolved_at__isnull=False).count()
1318
>>> qs = queryset.filter(channel=arc)
>>> qs.filter(resolved_at__isnull=False).count()
1356
>>> qs.filter(resolved_at__isnull=False, channel_filter__isnull=True).count()
38

@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label Jun 8, 2023
@matiasb matiasb requested a review from a team June 8, 2023 16:59
@matiasb matiasb added this pull request to the merge queue Jun 8, 2023
Merged via the queue into dev with commit c1935ef Jun 8, 2023
@matiasb matiasb deleted the matiasb/fix-ag-filter branch June 8, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants