Make viewset actions more consistent #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self.get_object() in all viewset actions
self.get_object() in all viewset actions
joeyorlando
reviewed
Jun 7, 2023
| @@ -41,6 +41,9 @@ class OnCallScheduleChannelView(RateLimitHeadersMixin, UpdateSerializerMixin, Mo | |||
| filter_backends = (filters.DjangoFilterBackend,) | |||
| filterset_class = ByTeamFilter | |||
|
|
|||
| # self.get_object() is not used in export action because ScheduleExportAuthentication is used | |||
| extra_actions_ignore_no_get_object = ["export"] | |||
There was a problem hiding this comment.
how is this attribute consumed?
There was a problem hiding this comment.
ohh nvm, I see it's used in the new unit test here. Nice! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Makes sure that all viewset actions with
detail=Trueuseself.get_object()to retrieve an instance that's being acted upon.Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)