Fix 500 on templates when slack or tg integration is disabled #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
reviewed
May 31, 2023
| @@ -325,9 +325,7 @@ def _handle_core_template_updates(self, data, ret): | |||
| """Update core templates if needed.""" | |||
| errors = {} | |||
|
|
|||
| core_template_names = self.CORE_TEMPLATE_NAMES | |||
There was a problem hiding this comment.
Do we need to remove CORE_TEMPLATE_NAMES too?
| @@ -343,7 +341,7 @@ def _handle_core_template_updates(self, data, ret): | |||
|
|
|||
| def to_representation(self, obj): | |||
| ret = super().to_representation(obj) | |||
| ret = self._get_templates_to_show(ret) | |||
| # ret = self._get_templates_to_show(ret) | |||
There was a problem hiding this comment.
left comment
if we don't need it _get_templates_to_show function can be removed
iskhakov
reviewed
May 31, 2023
| @@ -343,7 +324,6 @@ def _handle_core_template_updates(self, data, ret): | |||
|
|
|||
| def to_representation(self, obj): | |||
| ret = super().to_representation(obj) | |||
| ret = self._get_templates_to_show(ret) | |||
There was a problem hiding this comment.
do we need this function anymore?
iskhakov
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Continue the work, started in #2061.
Check if slack or telegram integration is enabled to include related templates in the response
Which issue(s) this PR fixes
#1889
Checklist