Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly address Organization.DoesNotExist resulting in HTTP 500 on Slack interactive_api_endpoint #2040

Merged
merged 10 commits into from
May 29, 2023
Merged

Properly address Organization.DoesNotExist resulting in HTTP 500 on Slack interactive_api_endpoint #2040

merged 10 commits into from
May 29, 2023

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented May 26, 2023 •
edited
Loading

Which issue(s) this PR fixes

Closes https://github.com/grafana/oncall-private/issues/1836

TODO:

  • add unit tests for this scenario

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required) (N/A)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label May 26, 2023
@joeyorlando joeyorlando requested a review from a team May 26, 2023 19:27
matiasb
matiasb approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeyorlando joeyorlando enabled auto-merge May 29, 2023 16:59
@joeyorlando joeyorlando added this pull request to the merge queue May 29, 2023
Merged via the queue into dev with commit 4ebc723 May 29, 2023
@joeyorlando joeyorlando deleted the jorlando/1836 branch May 29, 2023 17:11
@matiasb matiasb mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskhakov iskhakov iskhakov approved these changes

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeyorlando @matiasb @iskhakov