Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed notification title and subtitle; removed body #2027

Merged
merged 13 commits into from
May 26, 2023
Merged

changed notification title and subtitle; removed body #2027

merged 13 commits into from
May 26, 2023

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented May 25, 2023

What this PR does

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@imtoori imtoori requested a review from a team May 25, 2023 15:33
@imtoori imtoori added the pr:no public docs Added to a PR that does not require public documentation updates label May 25, 2023
@imtoori imtoori force-pushed the imtoori/notificationTitle branch from f90ce27 to 3a33b45 Compare May 26, 2023 08:14
@imtoori imtoori requested a review from Dieterbe May 26, 2023 08:15
joeyorlando
joeyorlando reviewed May 26, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
engine/apps/mobile_app/alert_rendering.py Outdated Show resolved Hide resolved
imtoori and others added 2 commits May 26, 2023 14:37
@imtoori @joeyorlando
Update CHANGELOG.md
088ba31 
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
@imtoori
emojize all subtitle
29f31af
@joeyorlando joeyorlando enabled auto-merge May 26, 2023 12:48
@joeyorlando joeyorlando added this pull request to the merge queue May 26, 2023
Merged via the queue into dev with commit 20a1964 May 26, 2023
@joeyorlando joeyorlando deleted the imtoori/notificationTitle branch May 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

@Dieterbe Dieterbe Awaiting requested review from Dieterbe

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imtoori @joeyorlando