Fix SQLite permission issue #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstpme
commented
May 22, 2023
| @@ -1,11 +1,8 @@ | |||
| from rest_framework.response import Response | |||
| from rest_framework.views import APIView | |||
|
|
|||
| from apps.telegram.tasks import register_telegram_webhook | |||
There was a problem hiding this comment.
Moving this to on_worker_ready so it doesn't fail with RabbitMQ connectivity error when building the docker image.
| @@ -19,9 +19,12 @@ RUN pip install -r requirements.txt | |||
| # https://stackoverflow.com/questions/34398632/docker-how-to-run-pip-requirements-txt-only-if-there-was-a-change/34399661#34399661 | |||
| COPY ./ ./ | |||
|
|
|||
| # Collect static files and create an SQLite database | |||
| RUN mkdir -p /var/lib/oncall | |||
| # Collect static files | |||
| RUN DJANGO_SETTINGS_MODULE=settings.prod_without_db DATABASE_TYPE=sqlite3 DATABASE_NAME=/var/lib/oncall/oncall.db SECRET_KEY="ThEmUsTSecretKEYforBUILDstage123" SILK_PROFILER_ENABLED="True" python manage.py collectstatic --no-input | |||
There was a problem hiding this comment.
Before removing this line, running python manage.py collectstatic was creating a DB file and everything worked as expected. After removing this line, the DB file is now created by a Celery worker which runs on a different user than uWSGI, which leads to a permission issue.
|
|
||
| # Create SQLite database and set permissions | ||
| RUN mkdir -p /var/lib/oncall | ||
| RUN DATABASE_TYPE=sqlite3 DATABASE_NAME=/var/lib/oncall/oncall.db python manage.py create_sqlite_db |
There was a problem hiding this comment.
Adding a new manage.py command that specifically creates a DB file so it's present in the docker image before setting permissions
joeyorlando
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #1960.
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)