Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dashboard for oncall metrics to provisioning plugin settings #1973

Merged
merged 12 commits into from
Jun 21, 2023
Merged

Add dashboard for oncall metrics to provisioning plugin settings #1973

merged 12 commits into from
Jun 21, 2023

Conversation

Ferril
Copy link
Member

@Ferril Ferril commented May 18, 2023 •
edited
Loading

Add dashboard for oncall metrics to the plugin settings by following this instruction. Dashboards files should be in .json format and stored in the plugin's directory in /src/dashboards/.
As the result the dashboard can be imported from the Dashboards tab at the plugin settings page:
Screenshot 2023-06-21 at 11 28 31

@Ferril Ferril marked this pull request as ready for review June 21, 2023 08:11
@Ferril Ferril requested a review from a team June 21, 2023 08:11
@Ferril Ferril force-pushed the oncall-metrics-dashboard branch from 8c419ec to e72421d Compare June 21, 2023 08:11
@Ferril Ferril added the pr:no public docs Added to a PR that does not require public documentation updates label Jun 21, 2023
joeyorlando
joeyorlando reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 do you mind adding some background context to the PR? (ex. why we want to store this .json file on the frontend?)

@Ferril Ferril changed the title Add draft dashboard for oncall metrics to provisioning plugin settings Add dashboard for oncall metrics to provisioning plugin settings Jun 21, 2023
@Ferril Ferril requested a review from joeyorlando June 21, 2023 09:34
Ferril and others added 2 commits June 21, 2023 11:58
@Ferril @joeyorlando
Change dashboard title
5040d39 
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
@Ferril @joeyorlando
Change dashboard title
5347ade 
Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
@Ferril Ferril added this pull request to the merge queue Jun 21, 2023
Merged via the queue into dev with commit 64976d6 Jun 21, 2023
@Ferril Ferril deleted the oncall-metrics-dashboard branch June 21, 2023 10:16
@matiasb matiasb mentioned this pull request Jun 22, 2023
Merged
brojd pushed a commit that referenced this pull request Sep 18, 2024
@Ferril @joeyorlando
Add dashboard for oncall metrics to provisioning plugin settings (#1973)
913ba3e 
Add dashboard for oncall metrics to the plugin settings by following
[this
instruction](https://community.grafana.com/t/how-to-include-dashboards-in-your-data-source-plugin/62749).
Dashboards files should be in `.json` format and stored in the plugin's
directory in `/src/dashboards/`.
As the result the dashboard can be imported from the `Dashboards` tab at
the plugin settings page:
<img width="1504" alt="Screenshot 2023-06-21 at 11 28 31"
src="https://github.com/grafana/oncall/assets/22730923/8c2bfe4a-f3c8-480a-b18c-7ba21a9b8e30">

---------

Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ferril @joeyorlando