Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack: use user_profile_changed event instead of user_change #1938

Merged
merged 3 commits into from
May 15, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented May 15, 2023

What this PR does

Adds a handler for user_profile_changed Slack event + updates the Slack app manifest.

This is needed to replace user_change event with user_profile_changed event, since using user_change can cause a lot of excessive requests from Slack.

Which issue(s) this PR fixes

Might be related to https://github.com/grafana/oncall-private/issues/1803

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme marked this pull request as ready for review May 15, 2023 16:27
@vstpme vstpme requested a review from a team May 15, 2023 16:27
@vstpme vstpme added this pull request to the merge queue May 15, 2023
Merged via the queue into dev with commit 64fd124 May 15, 2023
@vstpme vstpme deleted the vadimkerr/slack-user-change-event branch May 15, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants