Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add user settings for info notifications #1926

Merged
merged 10 commits into from
May 12, 2023
Merged

add user settings for info notifications #1926

merged 10 commits into from
May 12, 2023

Conversation

imtoori
Copy link
Contributor

@imtoori imtoori commented May 12, 2023 •
edited
Loading

What this PR does

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@imtoori imtoori added the pr:no public docs Added to a PR that does not require public documentation updates label May 12, 2023
@imtoori imtoori requested a review from a team May 12, 2023 08:04
vstpme
vstpme requested changes May 12, 2023
View reviewed changes
Copy link
Member

@vstpme vstpme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good 👍 Requesting changes for two minor things:

  • Generate Django migrations for the new fields in DB (make engine-manage CMD="makemigrations")
  • Format the code (make lint)

@imtoori imtoori added this pull request to the merge queue May 12, 2023
Merged via the queue into dev with commit c2ac74f May 12, 2023
@imtoori imtoori deleted the info-settings branch May 12, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstpme vstpme vstpme approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imtoori @vstpme