Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mobile app available to viewers #1892

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented May 8, 2023

What this PR does

closes #2153

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@joeyorlando joeyorlando requested a review from a team May 8, 2023 16:12
@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label May 8, 2023
Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs mobile app support before can be merged, right?

@joeyorlando
Copy link
Contributor Author

this needs mobile app support before can be merged, right?

@Dieterbe I believe the main thing the mobile app would need to change would be handling authorization. Viewers aren't allow to modify alert group state. If you try doing this atm it crashes the app because the HTTP request returns a 403. Aside from authorization, it appears to work as expected.

@joeyorlando joeyorlando enabled auto-merge June 13, 2023 18:40
@joeyorlando joeyorlando disabled auto-merge June 13, 2023 18:54
@joeyorlando joeyorlando merged commit 072d43c into dev Jun 13, 2023
@joeyorlando joeyorlando deleted the jorlando/make-mobile-app-available-to-viewers branch June 13, 2023 18:54
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does
closes #2153 

## Which issue(s) this PR fixes

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile app: Add correct handling of 403 when user tries to ack, resolve, silence alert group
3 participants