Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Notifications Receiver" RBAC role #1853

Merged
merged 8 commits into from
May 2, 2023

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Apr 29, 2023

What this PR does

Closes #1651

Plus, add developer instructions on how to run grafana-enterprise with RBAC for OnCall, enabled locally.

Todo

  • add API integration test for new permission query param filter

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

run grafana-enterprise with RBAC
enabled locally
@joeyorlando joeyorlando changed the title Add "Notifications Read" RBAC role Add "Notifications Receiver" RBAC role Apr 29, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified these docker-compose files to make it easier to switch between running the grafana or grafana-enterprise image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made this change so that a viewer w/ this new RBAC role can be assigned to a schedule rotation

@joeyorlando joeyorlando marked this pull request as ready for review May 1, 2023 15:33
@joeyorlando joeyorlando requested review from a team May 1, 2023 15:33
@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label May 2, 2023
Copy link
Member

@vstpme vstpme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine/apps/api/tests/test_user.py Show resolved Hide resolved
@joeyorlando joeyorlando enabled auto-merge May 2, 2023 12:14
@joeyorlando joeyorlando added this pull request to the merge queue May 2, 2023
Merged via the queue into dev with commit 0d4db59 May 2, 2023
@joeyorlando joeyorlando deleted the jorlando/rbac-notifications-read branch May 2, 2023 12:25
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does

Closes #1651 

Plus, add developer instructions on how to run `grafana-enterprise` with
RBAC for OnCall, enabled locally.

## Todo

- [x] add API integration test for new `permission` query param filter

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Notifications Read" RBAC role
3 participants