update web UI, Slack, and Telegram to allow silencing an acknowledged alert group #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even if alert group is acknowledged
|
Does this avoid the issue of re-entering firing state and notifying someone? Also should this be done across the board for Slack and other message backends in one PR? There is some conflict with docs |
iskhakov
approved these changes
Apr 27, 2023
teodosii
approved these changes
Apr 27, 2023
…:grafana/oncall into jorlando/show-alert-group-silence-button
joeyorlando
commented
Apr 27, 2023
There was a problem hiding this comment.
not related to this change, but fixing some grammatical things I came across
mderynck
approved these changes
Apr 27, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
… alert group (#1831) # What this PR does https://www.loom.com/share/1a6ef0d00c3b46ca80c120579d512dcc ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated (N/A) - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
https://www.loom.com/share/1a6ef0d00c3b46ca80c120579d512dcc
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)