Webhooks 2 Release #1830
Webhooks 2 Release #1830
Conversation
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
There was a problem hiding this comment.
LGTM 👍 frontend changes seem fine as well but may be worthwhile getting a 2nd 👍 from someone on @grafana/grafana-oncall-frontend.
You might want to checkout this frontend function, it makes a reference to outgoing_webhooks vs outgoing_webhooks_2. Seems related w/ determining which filters to fetch from the backend to render.
…mderynck/webhooks-2-ui-unification
| @@ -2,7 +2,6 @@ export const getApiPathByPage = (page: string) => { | |||
| return ( | |||
| { | |||
| outgoing_webhooks: 'custom_buttons', | |||
| outgoing_webhooks_2: 'webhooks', | |||
There was a problem hiding this comment.
Turns out we don't pass outgoing_webhooks_2 into this and rely on the fallback, webhooks is being passed in and returned.
- Enables new webhooks functionality. - Database migration will automatically convert existing webhooks to new ones. Note: Converted webhooks are considered "legacy" they will continue to work as part of your escalation chain but will no longer be editable. To make changes use the `Make a copy` action and edit that one, after you can delete your legacy webhook. Remember to connect your escalation chain with your newly copied webhook! --------- Co-authored-by: Maxim <maxim.mordasov@grafana.com>
Make a copyaction and edit that one, after you can delete your legacy webhook. Remember to connect your escalation chain with your newly copied webhook!