Optimize duplicate queries occurring in AlertGroupFilter #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlertGroupFilter
iskhakov
approved these changes
Apr 24, 2023
iskhakov
reviewed
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In
AlertGroupFilterwe currently have 11 duplicate queries which add ~1-2secs of unecessary request latency toGET /api/internal/v1/alertgroupscalls.The queries originate from the
querysetcallable arguments on several of the fields of theAlertGroupFilterclass. These callables basically filter down their respective querysets to include only objects that belong to the currently authenticated user's organization.The duplicate queries are
At the moment, this PR is still a draft and doesn't work as intended. It's based off of a suggestion from this discussion in the
django-filterrepo. See this DjangoCon talk for more context.