Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add channel__team to internal api serializer select_related #1805

Merged
merged 2 commits into from
Apr 20, 2023
Merged

add channel__team to internal api serializer select_related #1805

merged 2 commits into from
Apr 20, 2023

Conversation

joeyorlando
Copy link
Contributor

Locally I reproduced a slow GET /api/internal/v1/alertgroups query (took 9s - 10s). After adding this line to the alert group serializer for the internal api it:

  • cut the response time in half
  • cut the number of executed SQL queries from 52 to 30

@joeyorlando joeyorlando requested a review from a team April 20, 2023 16:01
@joeyorlando joeyorlando added the pr:no public docs Added to a PR that does not require public documentation updates label Apr 20, 2023
@joeyorlando joeyorlando merged commit 1650220 into dev Apr 20, 2023
@joeyorlando joeyorlando deleted the jorlando/improve-alert-groups-endpoint-speed branch April 20, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mderynck mderynck mderynck approved these changes

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joeyorlando @matiasb @mderynck