Limit number of alertmanager alerts in alert group to autoresolve #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
commented
Apr 18, 2023
| @@ -145,7 +145,7 @@ class AlertGroup(AlertGroupSlackRenderingMixin, EscalationSnapshotMixin, models. | |||
| "GroupData", ["is_resolve_signal", "group_distinction", "web_title_cache", "is_acknowledge_signal"] | |||
| ) | |||
|
|
|||
| SOURCE, USER, NOT_YET, LAST_STEP, ARCHIVED, WIPED, DISABLE_MAINTENANCE = range(7) | |||
| SOURCE, USER, NOT_YET, LAST_STEP, ARCHIVED, WIPED, DISABLE_MAINTENANCE, NOT_YET_STOP_AUTORESOLVE = range(8) | |||
There was a problem hiding this comment.
not the most elegant solution, but we already have source NOT_YET, so adding NOT_YET_STOP_AUTORESOLVE.
I don't want to add the new flag for that
iskhakov
commented
Apr 18, 2023
| @@ -22,6 +22,11 @@ def resolve_alert_group_by_source_if_needed(alert_group_pk): | |||
| alert_group.active_resolve_calculation_id | |||
| ) | |||
| else: | |||
| if alert_group.resolved_by == alert_group.NOT_YET_STOP_AUTORESOLVE: | |||
| return "alert_group is too big to auto-resolve" | |||
| if alert_group.alerts.count() > AlertGroupForAlertManager.MAX_ALERTS_IN_GROUP_FOR_AUTO_RESOLVE: | |||
There was a problem hiding this comment.
if more than N alerts in alert group, set the flag and make the last attempt to autoresolve
iskhakov
commented
Apr 18, 2023
engine/apps/integrations/tasks.py
Outdated
Comment on lines
61
to
65
| alert_group = alert.group | ||
| if alert_group.resoved_by != alert_group.NOT_YET_STOP_AUTORESOLVE: | ||
| task = resolve_alert_group_by_source_if_needed.apply_async((alert.group.pk,), countdown=5) | ||
| alert.group.active_resolve_calculation_id = task.id | ||
| alert.group.save(update_fields=["active_resolve_calculation_id"]) |
There was a problem hiding this comment.
if alert group has flag set, don't even start the task. This will decrease the number of load to the database
Matvey-Kuk
approved these changes
Apr 18, 2023
| @@ -22,6 +22,11 @@ def resolve_alert_group_by_source_if_needed(alert_group_pk): | |||
| alert_group.active_resolve_calculation_id | |||
| ) | |||
| else: | |||
| if alert_group.resolved_by == alert_group.NOT_YET_STOP_AUTORESOLVE: | |||
| return "alert_group is too big to auto-resolve" | |||
| if alert_group.alerts.count() > AlertGroupForAlertManager.MAX_ALERTS_IN_GROUP_FOR_AUTO_RESOLVE: | |||
3 tasks
joeyorlando
added a commit
that referenced
this pull request
May 8, 2023
# What this PR does `SOURCE_CHOICES` was updated in #1779 but we forgot to include the accompanying database migration. If you run `make engine-manage CMD="makemigrations"`, this migration is output. This PR simply adds that. ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated (N/A) - [ ] Documentation added (or `pr:no public docs` PR label added if not required) (N/A) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) (N/A)
iskhakov
pushed a commit
that referenced
this pull request
May 12, 2023
# What this PR does `SOURCE_CHOICES` was updated in #1779 but we forgot to include the accompanying database migration. If you run `make engine-manage CMD="makemigrations"`, this migration is output. This PR simply adds that. ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated (N/A) - [ ] Documentation added (or `pr:no public docs` PR label added if not required) (N/A) - [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) (N/A)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR set the limit so that workers won't attempt to autoresolve too big alertmanager alert groups.
Which issue(s) this PR fixes
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)