Fix web_link property of AlertGroup
#1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web_link property of AlertGroup
92aab35 to
a95276c
Compare
The routing of the OnCall plugin has changed and no longer uses URL params but instead uses paths. This link is used when declaring an Incident from the OnCall Slack alert and needs to match the correct pattern in order for Incident to correctly detect it.
a95276c to
3595301
Compare
mderynck
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The routing of the OnCall plugin has changed and no longer uses URL params
but instead uses paths. This link is used when declaring an Incident from
the OnCall Slack alert and needs to match the correct pattern in order for
Incident to correctly detect it.