Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send demo alert with dynamic payload and get demo payload example on private api #1700

Merged
merged 13 commits into from
Apr 18, 2023

Conversation

iskhakov
Copy link
Contributor

@iskhakov iskhakov commented Apr 5, 2023

What this PR does

  • Added demo_alert_payload field to /api/internal/v1/alert_receive_channels/ GET endpoint
curl 'http://localhost:3000/api/plugin-proxy/grafana-oncall-app/api/internal/v1/alert_receive_channels/'

Screenshot 2023-04-21 at 13 21 14

  • Added demo_alert_payload field to /api/internal/v1/alert_receive_channels/***/send_demo_alert/ POST endpoint
curl 'http://localhost:3000/api/plugin-proxy/grafana-oncall-app/api/internal/v1/alert_receive_channels/***/send_demo_alert/' \
  -XPOST -H 'Content-Type: application/json' \
  --data-raw '{"demo_alert_payload":{"alerts":[{"a":"b"}]}}' \
  --compressed

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@iskhakov iskhakov requested a review from a team April 5, 2023 03:51
@iskhakov
Copy link
Contributor Author

iskhakov commented Apr 6, 2023

todo return with integrations/

@iskhakov iskhakov self-assigned this Apr 12, 2023
@iskhakov iskhakov marked this pull request as draft April 14, 2023 04:03
@iskhakov iskhakov force-pushed the iskhakov/send-demo-alert-with-any-payload branch from 6580fe9 to 0db2df0 Compare April 14, 2023 05:01
@iskhakov iskhakov changed the title Send demo payload with any payload and get demo payload example [Ready] Send demo payload with any payload and get demo payload example Apr 17, 2023
@iskhakov iskhakov marked this pull request as ready for review April 17, 2023 09:48
@iskhakov iskhakov changed the title [Ready] Send demo payload with any payload and get demo payload example Send demo alert with dynamic payload and get demo payload example on private api Apr 18, 2023
@iskhakov iskhakov enabled auto-merge April 18, 2023 02:42
@iskhakov iskhakov added this pull request to the merge queue Apr 18, 2023
Merged via the queue into dev with commit f825fdf Apr 18, 2023
@iskhakov iskhakov deleted the iskhakov/send-demo-alert-with-any-payload branch April 18, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants