Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix team search #1680

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Fix team search #1680

merged 3 commits into from
Mar 30, 2023

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Mar 30, 2023 •
edited
Loading

What this PR does

Team search doesn't work when filtering by team:

Screenshot 2023-03-30 at 15 48 50

This PR fixes it + adds backend unit tests.

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 30, 2023
@vstpme vstpme marked this pull request as ready for review March 30, 2023 14:53
@vstpme vstpme requested a review from a team March 30, 2023 14:53
matiasb
matiasb approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, question/thought added.

engine/apps/api/views/team.py Outdated Show resolved Hide resolved
@vstpme vstpme enabled auto-merge March 30, 2023 15:19
@vstpme vstpme added this pull request to the merge queue Mar 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2023
@vstpme vstpme added this pull request to the merge queue Mar 30, 2023
Merged via the queue into dev with commit ac57c8e Mar 30, 2023
@vstpme vstpme deleted the vadimkerr/fix-teams-search branch March 30, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstpme @matiasb