fix safari scroll #1663
fix safari scroll #1663
Conversation
There was a problem hiding this comment.
can you uncomment out the Safari browser in the e2e tests here?
|
@joeyorlando I enabled tests on Safari |
009580e to
73265da
Compare
function more robust
…l into maxim/fix-safari-scrolling
| @@ -39,7 +39,7 @@ export const clickButton = async ({ | |||
| dataTestId, | |||
| }: ClickButtonArgs): Promise<void> => { | |||
| const baseLocator = dataTestId ? `button[data-testid="${dataTestId}"]` : 'button'; | |||
| const button = (startingLocator || page).locator(`${baseLocator} >> text=${buttonText}`); | |||
| const button = (startingLocator || page).locator(`${baseLocator}:not([disabled]) >> text=${buttonText}`); | |||
There was a problem hiding this comment.
this should make some of the flaky schedules tests more reliable.. I think the issue was that the tests were trying to click on the "Add rotation" button, which according to this screenshot, starts off disabled. So it would click the disabled button and then expect for something to become available.. but obviously it wouldn't because the button click did nothing.
By adding this, Playwright should wait until the desired button is enabled before trying to click it:
There was a problem hiding this comment.
hmm, create rotation button is disabled when creation form is already opened and it's always disabled for non-web schedules, i'm not sure what happened in that case...
…l into maxim/fix-safari-scrolling
# What this PR does Fix scroll in Safari ## Which issue(s) this PR fixes #415 ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not required) --------- Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com> Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
What this PR does
Fix scroll in Safari
Which issue(s) this PR fixes
#415
Checklist
pr:no public docsPR label added if not required)CHANGELOG.mdupdated (orpr:no changelogPR label added if not required)