RRULE until values must be specified in UTC tz #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstpme
approved these changes
Mar 30, 2023
| @@ -584,8 +584,8 @@ def event_ical_rules(self): | |||
| if self.week_start is not None: | |||
| rules["wkst"] = CustomOnCallShift.ICAL_WEEKDAY_MAP[self.week_start] | |||
| if self.until is not None: | |||
| time_zone = self.time_zone if self.time_zone is not None else "UTC" | |||
| rules["until"] = self.convert_dt_to_schedule_timezone(self.until, time_zone) | |||
| # RRULE UNTIL values must be specified in UTC when DTSTART is timezone-aware | |||
There was a problem hiding this comment.
Maybe a good place to add a TODO on supporting timezone-aware RRULE UNTIL?
joeyorlando
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating ical information for an event, the RRULE until value must be specified in UTC.
Related to https://github.com/grafana/support-escalations/issues/5426.