Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing team for escalation chains #1658

Merged
merged 10 commits into from
Mar 30, 2023

Conversation

maskin25
Copy link
Contributor

@maskin25 maskin25 commented Mar 29, 2023

What this PR does

Allows changing team for escalation chains

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@maskin25 maskin25 added the pr:no public docs Added to a PR that does not require public documentation updates label Mar 29, 2023
@maskin25 maskin25 requested a review from a team March 29, 2023 11:51
@iskhakov iskhakov requested a review from a team March 29, 2023 13:11
@iskhakov iskhakov added this pull request to the merge queue Mar 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2023
Copy link
Member

@teodosii teodosii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed a small bug here. When you create an escalation chain, the form is validated, when you set a copy the validation is no longer performed and you can have empty text escalation chains.

image
image

This only happens for copying, updating/creating does trigger the validation.

@vstpme
Copy link
Member

vstpme commented Mar 30, 2023

The empty name bug is fixed in 4f076ce. cc @teodosii

@vstpme vstpme merged commit 061123e into dev Mar 30, 2023
@vstpme vstpme deleted the maxim/allow-move-escalation-chains-between-teams branch March 30, 2023 09:43
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does

Allows changing team for escalation chains

## Which issue(s) this PR fixes

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)

---------

Co-authored-by: Ildar Iskhakov <ildar.iskhakov@grafana.com>
Co-authored-by: Vadim Stepanov <vadimkerr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants